Skip to content
  • Mads Kiilerich's avatar
    largefiles: for update -C, only update largefiles when necessary · 9d5c27890790
    Mads Kiilerich authored
    Before, a --clean update with largefiles would use the "optimization" that it
    didn't read hashes from standin files before and after the update. Instead of
    trusting the content of the standin files, it would rehash all the actual
    largefiles that lfdirstate reported clean and update the standins that didn't
    have the expected content. It could thus in some "impossible" situations
    automatically recover from some "largefile got out sync with its standin"
    issues (even there apparently still were weird corner cases where it could
    fail). This extra checking is similar to what core --clean intentionally do
    not do, and it made update --clean unbearable slow.
    
    Usually in core Mercurial, --clean will rely on the dirstate to find the files
    it should update. (It is thus intentionally possible (when trying to trick the
    system or if there should be bugs) to end up in situations where --clean not
    will restore the working directory content correctly.) Checking every file when
    we "know" it is ok is however not an option - that would be too slow.
    
    Instead, trust the content of the standin files. Use the same logic for --clean
    as for linear updates and trust the dirstate and that our "logic" will keep
    them in sync. It is much cheaper to just rehash the largefiles reported dirty
    by a status walk and read all standins than to hash largefiles.
    
    Most of the changes are just a change of indentation now when the different
    kinds of updates no longer are handled that differently. Standins for added
    files are however only written when doing a normal update, while deleted and
    removed files only will be updated for --clean updates.
    9d5c27890790