Skip to content
  • Pierre-Yves David's avatar
    changelog: never inline changelog · dcaa2df1f688
    Pierre-Yves David authored
    The test suite mostly use small repositories, that implies that most changelog in the
    tests are inlined. As a result, non-inlined changelog are quite poorly tested.
    Since non-inline changelog are most common case for serious repositories, this
    lack of testing is a significant problem that results in high profile issue like
    the one recently fixed by 66417f55ea33 and 849745d7da89.
    
    Inlining the changelog does not bring much to the table, the number of total
    file saved is negligible, and the changelog will be read by most operation
    anyway.
    
    So this changeset is make it so we never inline the changelog, and de-inline the
    one that are still inlined whenever we touch them.
    
    By doing that, we remove the "dual code path" situation for writing new entry to
    the changelog and move to a "single code path" situation. Having a single
    code path simplify the code and make sure it is covered by test (if test cover
    that situation obviously)
    
    
    This impact all tests that care about the number of file and the exchange size,
    but there is nothing too complicated in them just a lot of churn.
    
    The churn is made "worse" by the fact rust will use the persistent nodemap on
    any changelog now. Which is overall a win as it means testing the persistent
    nodemap more and having less special cases.
    
    In short, having inline changelog is mostly useless and an endless source of
    pain. We get rid of it.
    dcaa2df1f688