Skip to content
  • Manuel Jacob's avatar
    node: stop converting binascii.Error to TypeError in bin() · 63fd0282ad40
    Manuel Jacob authored
    Changeset f574cc00831a introduced the wrapper, to make bin() behave like on
    Python 2, where it raised TypeError in many cases. Another previous approach,
    changing callers to catch binascii.Error in addition to TypeError, was backed
    out after negative review feedback [1].
    
    However, I think it’s worth reconsidering the approach. Now that we’re on
    Python 3 only, callers have to catch only binascii.Error instead of both.
    Catching binascii.Error instead of TypeError has the advantage that it’s less
    likely to cover a programming error (e.g. passing an int to bin() raises
    TypeError). Also, raising TypeError never made sense semantically when bin()
    got an argument of valid type.
    
    As a side-effect, this fixed an exception in test-http-bad-server.t. The TODO
    was outdated: it was not an uncaught ValueError in batch.results() but uncaught
    TypeError from the now removed wrapper. Now that bin() raises binascii.Error
    instead of TypeError, it gets converted to a proper error in
    wirepeer.heads.<locals>.decode() that catches ValueError (superclass of
    binascii.Error). This is a good example of why this changeset is a good idea.
    Catching TypeError instead of ValueError there would not make much sense.
    
    [1] https://phab.mercurial-scm.org/D2244
    63fd0282ad40